[PATCH] D104766: [X86] Zero some outputs of Keylocker intrinsics in error case

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14834
 
+    BasicBlock *NoError = createBasicBlock(StrNoErr, this->CurFn);
+    BasicBlock *Error = createBasicBlock(StrErr, this->CurFn);
----------------
Sorry I'm late here. Instead of having 3 separate strings for each intrinsic can you do something like `createBasicBlock(BaseName + "_no_error"...)` here. I believe createBasicBlock takes a Twine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104766/new/

https://reviews.llvm.org/D104766