[PATCH] D105254: [RISCV] Support machine constraint "S"

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 30 19:44:24 PDT 2021


MaskRay added a comment.

In D105254#2851889 <https://reviews.llvm.org/D105254#2851889>, @jrtc27 wrote:

> Hm, AArch64 handles ExternalSymbolSDNode too, but I don't see how you could ever end up with one...

It can't and the code path is untested. I already deleted it from aarch64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105254/new/

https://reviews.llvm.org/D105254



More information about the cfe-commits mailing list