[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 28 23:26:55 PDT 2021


nridge planned changes to this revision.
nridge added a comment.

In D104619#2846262 <https://reviews.llvm.org/D104619#2846262>, @dblaikie wrote:

> If there's already some duplication, perhaps a pre-patch to generalize that functionality, then using that functionality in this patch?

Sounds good, will give that a try.

> Alternatively: Types are decls, perhaps this test should go in the existing DeclPrinterTest?

Types often have corresponding decls (not always, e.g. `BuiltinType`), but they're distinct hierarchies (e.g. `RecordType` and `RecordDecl` can be thought of as "corresponding", but they're not related by inheritance, instead deriving from `Type` and `Decl` respectively). `DeclPrinterTest` exercises `Decl::print()`, while we want `TypePrinterTest` to exercise `Type::print()`, so I think a distinct file makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104619/new/

https://reviews.llvm.org/D104619



More information about the cfe-commits mailing list