[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 28 23:18:34 PDT 2021


dblaikie added a comment.

In D104619#2846259 <https://reviews.llvm.org/D104619#2846259>, @nridge wrote:

> In D104619#2846258 <https://reviews.llvm.org/D104619#2846258>, @dblaikie wrote:
>
>> if that's the case, maybe there's room to refactor the commonality - avoiding the near(if it is near) duplication and justifying the complexity/more general design a bit more, by having more uses to generalize over?
>
> That had occurred to me as well. I'm happy to try!
>
> Would it perhaps make sense to do that in a follow-up patch?

If there's already some duplication, perhaps a pre-patch to generalize that functionality, then using that functionality in this patch?

Alternatively: Types are decls, perhaps this test should go in the existing DeclPrinterTest?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104619/new/

https://reviews.llvm.org/D104619



More information about the cfe-commits mailing list