[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

Ben Shi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 8 23:30:25 PDT 2021


benshi001 added a comment.

In D103878#2807034 <https://reviews.llvm.org/D103878#2807034>, @MaskRay wrote:

> How do the new tests provide additional coverage?

For these tests,

1. there is no tests for mabi=ilp32e, and my patch covers that.
2. the tests in riscv-abi.c will show default abi changes for special archs, especially for the arch with F but without D extension, in the future.
3. the tests in riscv-arch.c will show default arch changes for abi=ilp32, which is rv32imacfd now, and it is better to be rv32imac. for abi=ilp32f it is better arch=imacf than current imacfd.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103878/new/

https://reviews.llvm.org/D103878



More information about the cfe-commits mailing list