[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

Ben Shi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 8 23:24:06 PDT 2021


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: clang/test/Driver/riscv-arch.c:45
+
+// CHECK-ILP32:      "-target-feature" "+m"
+// CHECK-ILP32-SAME: "-target-feature" "+f"
----------------
MaskRay wrote:
> I suggest the style used in linux-cross.cpp
> 
> Just using `-SAME` cannot detect unrelated strings between "-target-feature" "+m" and "-target-feature" "+f"
Thanks for your suggestion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103878/new/

https://reviews.llvm.org/D103878



More information about the cfe-commits mailing list