[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

[Leonard Chan via Phabricator via cfe-commits]

leonardchan added a comment.

Oh, actually @pcc was right on closer inspection. This is a misunderstanding on my end. So the `{{bt:...}}}` comes from

  constexpr const char *kFormatFrame = "{{{bt:%u:%p}}}";

defined in `sanitizer_symbolizer_fuchsia.h` and this is only used in the definition for `RenderFrame` in `sanitizer_symbolizer_markup.cpp`:

  void RenderFrame(InternalScopedString *buffer, const char *format, int frame_no,
                   uptr address, const AddressInfo *info, bool vs_style,
                   const char *strip_path_prefix, const char *strip_func_prefix) {
    CHECK(!RenderNeedsSymbolization(format));
    buffer->append(kFormatFrame, frame_no, address);
  }

and it's here where a newline isn't being added. The `format` isn't used at all. So it might be more appropriate to either just add a newline to those formats (or this `append`) or go ahead and add the newline to the Printf call on line 244.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103845/new/

https://reviews.llvm.org/D103845