[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

Evgenii Stepanov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 8 12:15:53 PDT 2021


eugenis added a comment.

In D103845#2806211 <https://reviews.llvm.org/D103845#2806211>, @leonardchan wrote:

> I think the newline gets added to the frame description only if `Symbolizer::GetOrInit()->SymbolizePC(pc)` is nonnull, so if it fails then no newline is added.

This makes sense to me. This boils down to ListOfModules being unimplemented on Fuschia, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103845/new/

https://reviews.llvm.org/D103845



More information about the cfe-commits mailing list