[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

Matheus Izvekov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 8 12:22:35 PDT 2021


mizvekov added a comment.

In D103720#2806147 <https://reviews.llvm.org/D103720#2806147>, @aaron.ballman wrote:

> (esp if someone in the future wants to add `Expr::isRValue()` with the C++ meaning of prvalue || xvalue).

@rsmith actually suggested we add `isRValue` as a second step here, and I think it's a good idea, but I was also
worried a bit about the practical issue:
Others rebasing patches on top of that change without realizing it, and introducing possibly subtle issues :)
We could wait just a little bit for that and let others just soak in the build breakage meanwhile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103720/new/

https://reviews.llvm.org/D103720



More information about the cfe-commits mailing list