[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 8 11:33:46 PDT 2021


aaron.ballman added a comment.

Thank you for the terminology cleanup! I'm not opposed to the changes, but I am wondering whether the churn is worth it given that the nomenclature will still be confusing for those thinking about non-C++ based languages (esp if someone in the future wants to add `Expr::isRValue()` with the C++ meaning of prvalue || xvalue). Either way, I think the confusion will likely be relatively minor and temporary.

@rsmith, what say you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103720/new/

https://reviews.llvm.org/D103720



More information about the cfe-commits mailing list