[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

[Yuanfang Chen via Phabricator via cfe-commits]

ychen added a comment.

In D103885#2805988 <https://reviews.llvm.org/D103885#2805988>, @aaron.ballman wrote:

> In D103885#2805758 <https://reviews.llvm.org/D103885#2805758>, @ychen wrote:
>
>> We could use a table to avoid the warning and speed the build a little bit. https://reviews.llvm.org/D98110
>
> That's an interesting approach, thank you for sharing it! I wonder how use of a table impacts performance given that the table is on the stack and there can be a lot of options (a bit less worried for things like OpenMP kinds or overloadable operators as those as much smaller)?

I think performance should be better if there are noticeable differences at all. The code footprint is much smaller although there are additional data loads that are most likely in the cache.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103885/new/

https://reviews.llvm.org/D103885