[PATCH] D103526: [clang][deps] Handle modular dependencies present in PCH

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 8 04:13:39 PDT 2021


jansvoboda11 added inline comments.


================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:125
+      ImportCollectingListener Listener(PrebuiltModuleFiles);
+      ASTReader::readASTFileControlBlock(
+          Compiler.getPreprocessorOpts().ImplicitPCHInclude,
----------------
I'd expect to have to do this recursively for each `IMPORT` in the PCH, since AST files list only direct imports.

However, the AST file for PCH I use in tests contains imports of `ModCommon1`, `ModCommon2`, `ModPCH` even though only `ModCommon1` and `ModPCH` are imported directly in the header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103526/new/

https://reviews.llvm.org/D103526



More information about the cfe-commits mailing list