[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

Momchil Velikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 1 08:15:05 PDT 2021


chill added a comment.

IMHO, it's possible to write a frontend test, which includes, say `arm_neon.h`, but does not really require the `ARM` or `AArch64` backends to be configured (e.g. `CodeGen/arm-vector-align.c`?)
If `arm_neon.h` is not built, then the test would need the appropriate `REQUIRES` line, but than that means the frontend test coverage would decrease for people, who
are not interested in Arm backends. Mind you, even if a test is Arm specific, that does not mean it does not depend on generic code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103080/new/

https://reviews.llvm.org/D103080



More information about the cfe-commits mailing list