[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

Tue Jun 1 08:10:34 PDT 2021

kristof.beyls added a comment.

In D103080#2790139 <https://reviews.llvm.org/D103080#2790139>, @sunlin wrote:

> Hi @kristof.beyls The  original `lib/clang/12.0.1/include` is about total ~10M, and the `arm*.h` take about ~5M. Ignore these unused header files will save the developers who work on the low storage device.

Thanks for sharing that rationale!
I have two immediate thoughts on this patch:

- arm_neon.h and other header files need to be kept also for the AArch64 backend. As is, I think the patch will remove them resulting in a broken toolchain if the AArch64 backend is requested but the Arm backend is not.
- We should implement either (a) remove all target-specific header files if a target is not built or (b) keep all of them. Selecting ad hoc (e.g. applying this design principle only for the Arm backend) which ones to apply this policy to doesn't seem like a good design to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103080/new/

https://reviews.llvm.org/D103080