[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

[Nathan Sidwell via Phabricator via cfe-commits]

urnathan added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:4623
 
-  Expected<UsingDecl *> ToUsingOrErr = import(D->getUsingDecl());
-  if (!ToUsingOrErr)
-    return ToUsingOrErr.takeError();
+  Expected<BaseUsingDecl *> ToIntroducerOrErr = import(D->getIntroducer());
+  if (!ToIntroducerOrErr)
----------------
shafik wrote:
> It would nice to expand upon the  `ImportUsingShadowDecl` in `ASTImporterTest.cpp` as we expand this change to make sure the ASTImporter is importing all the cases correctly. Right now we just have a very basic test there.
Please clarify what you are requiring of this patch series. What you describe sounds like an orthogonal desire.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101777/new/

https://reviews.llvm.org/D101777