[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl
Shafik Yaghmour via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 18 09:49:17 PDT 2021
shafik added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:4623
- Expected<UsingDecl *> ToUsingOrErr = import(D->getUsingDecl());
- if (!ToUsingOrErr)
- return ToUsingOrErr.takeError();
+ Expected<BaseUsingDecl *> ToIntroducerOrErr = import(D->getIntroducer());
+ if (!ToIntroducerOrErr)
----------------
It would nice to expand upon the `ImportUsingShadowDecl` in `ASTImporterTest.cpp` as we expand this change to make sure the ASTImporter is importing all the cases correctly. Right now we just have a very basic test there.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101777/new/
https://reviews.llvm.org/D101777
More information about the cfe-commits
mailing list