[PATCH] D100276: [clang] p1099 3/5: using Enum::member

Nathan Sidwell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 14 10:39:09 PDT 2021


urnathan marked 5 inline comments as done.
urnathan added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12370
     // If we weren't able to compute a valid scope, it might validly be a
     // dependent class scope or a dependent enumeration unscoped scope. If
     // we have a 'typename' keyword, the scope must resolve to a class type.
----------------
bruno wrote:
> Does this comment needs update?
I don't think so. 'if we weren't able to compute a scope' is never true for the using-enum case (and neither is 'if we have a typename keyword'.  what is it that you're finding confusing here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100276/new/

https://reviews.llvm.org/D100276



More information about the cfe-commits mailing list