[PATCH] D100276: [clang] p1099 3/5: using Enum::member

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 13 23:18:46 PDT 2021


bruno added a comment.

Overall looks good, one more comment below.



================
Comment at: clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp:20
 class C {
+public:
   int g();
----------------
bruno wrote:
> > The change to clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp is to silence an uninteresting access error that the above change causes.
> 
> The fact that the access check changed for previous version of the language (not necessarily related to p1099) indicates that this specific change deserves its own patch.
How about this one?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100276/new/

https://reviews.llvm.org/D100276



More information about the cfe-commits mailing list