[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 12 12:55:16 PDT 2021


lebedev.ri added inline comments.


================
Comment at: clang/lib/CodeGen/CGVTables.cpp:467
+  if (!CalleeMD->isDefined()) {
+    CGM.ErrorUnsupported(ThunkGD.getDecl(), "thunk for forward declaration");
+    return;
----------------
efriedma wrote:
> "IsUnprototyped" means that we have to generate a thunk, but we don't have the proper types. We emit some special IR with known incorrect types, and mark it with the "thunk" attribute to let the optimizer know what we're doing.
> 
> It should be fine to continue using a fake type on the IsUnprototyped codepath.
`IsUnprototyped` is false here for that test though..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100388/new/

https://reviews.llvm.org/D100388



More information about the cfe-commits mailing list