[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 12 11:46:22 PDT 2021


lebedev.ri added a comment.

In D100388#2754872 <https://reviews.llvm.org/D100388#2754872>, @efriedma wrote:

>> Would it be reasonable to instead start with a stopgap measure of not adding attributes for this/return of thunks?
>
> You mean, add align attributes to "this" on regular methods, but not thunks?

Yes, just so the rG6270b3a1eafaba4279e021418c5a2c5a35abc002 <https://reviews.llvm.org/rG6270b3a1eafaba4279e021418c5a2c5a35abc002> can be reverted.
Unless of course we can get this going..

> I can't see how that could do any harm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100388/new/

https://reviews.llvm.org/D100388



More information about the cfe-commits mailing list