[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

Utkarsh Saxena via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 4 15:19:00 PDT 2021


usaxena95 accepted this revision.
usaxena95 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:9
 function(gen_decision_forest model filename cpp_class)
-  set(model_compiler ${LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR}/clangd/quality/CompletionModelCodegen.py)
+  set(model_compiler ${CLANGD_COMPLETION_MODEL_COMPILER})
 
----------------
We can remove this variable as well and use the above var at all places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101851/new/

https://reviews.llvm.org/D101851



More information about the cfe-commits mailing list