[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

[Harald van Dijk via Phabricator via cfe-commits]

hvdijk marked an inline comment as done.
hvdijk added inline comments.


================
Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:7
 # namespace-qualified class name.
+set(CLANGD_QUALITY_DIR ${CMAKE_CURRENT_LIST_DIR})
 function(gen_decision_forest model filename cpp_class)
----------------
usaxena95 wrote:
> nit: Directly refer to code generator instead of storing quality dir.
> `set(CLANGD_COMPLETION_MODEL_COMPILER ${CMAKE_CURRENT_LIST_DIR}/CompletionModelCodegen.py)`
Alright, done. Testing in progress just to be on the safe side. We could also get rid of `model_compiler` and use `${CLANGD_COMPLETION_MODEL_COMPILER}` directly, but I felt that looked bad due to the conflicting variable naming styles and the long lines, so I left that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101851/new/

https://reviews.llvm.org/D101851