[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

In D100980#2722207 <https://reviews.llvm.org/D100980#2722207>, @azabaznov wrote:

>> Not sure what do we want to achieve with this? Do you want to point out that the code might be somehow less portable let's say between clang revisions, etc?
>
> My main worry is that you are changing the behaviour here: kernels which fail to compile will compile successfully. I suggest not to do it silently but issue a warning/note instead.

Ok, this should technically not be an issue as it does not break backward compatibility but it could still be useful for the portability reasons especially in the transition period while we still accept but deprecate pragmas. Perhaps we could even use such a flag elsewhere for similar purposes.

However, what I don't like about it is that we will still need to check for whether the pragma is enabled in the compiler source code so it won't be simpler. Anyway I guess the best way is to prepare a patch and then we can take a look and decide whether we can go ahead with it or stick to an old solution with pragma for the time being.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100980/new/

https://reviews.llvm.org/D100980