[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anton Zabaznov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 28 03:43:05 PDT 2021


azabaznov added a comment.

> Not sure what do we want to achieve with this? Do you want to point out that the code might be somehow less portable let's say between clang revisions, etc?

My main worry is that you are changing the behaviour here: kernels which fail to compile will compile successfully. I suggest not to do it silently but issue a warning/note instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100980/new/

https://reviews.llvm.org/D100980



More information about the cfe-commits mailing list