[PATCH] D100368: [X86] Support some missing intrinsics

Pengfei Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 14 20:15:56 PDT 2021


pengfei added inline comments.


================
Comment at: clang/lib/Headers/avx512fintrin.h:9611
+/// starting at location \a base_addr at packed 32-bit integer indices stored in
+/// the lower half of \a vindex scaled by \a scale into dst using writemask
+/// \a mask (elements are copied from \a src when the corresponding mask bit is
----------------
craig.topper wrote:
> Use of "dst" here doesn't make sense since it isn't a parameter name so shouldn't be abbreviated.
Can we arrange "dst" as the abbreviation for the result of the intrinsic?
Intrinsic guide uses such naming conversion and correspondings to its operation.
We are trying to unify the descriptions here and intrinsic guide.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100368/new/

https://reviews.llvm.org/D100368



More information about the cfe-commits mailing list