[PATCH] D100368: [X86] Support some missing intrinsics

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/Headers/avx512fintrin.h:9593
+/// locations starting at location \a base_addr at packed 32-bit integer indices
+/// stored in the lower half of \a vindex scaled by \a scale them in dst.
+///
----------------
"scale them in dst" doesn't make sense.


================
Comment at: clang/lib/Headers/avx512fintrin.h:9611
+/// starting at location \a base_addr at packed 32-bit integer indices stored in
+/// the lower half of \a vindex scaled by \a scale into dst using writemask
+/// \a mask (elements are copied from \a src when the corresponding mask bit is
----------------
Use of "dst" here doesn't make sense since it isn't a parameter name so shouldn't be abbreviated.


================
Comment at: clang/lib/Headers/avx512fintrin.h:9636
+/// at packed 32-bit integer indices stored in the lower half of \a vindex
+/// scaled by \a scale and stores them in dst.
+///
----------------
Same


================
Comment at: clang/lib/Headers/avx512fintrin.h:9654
+/// at packed 32-bit integer indices stored in the lower half of \a vindex
+/// scaled by \a scale and stores them in dst using writemask \a mask (elements
+/// are copied from \a src when the corresponding mask bit is not set).
----------------
Same


================
Comment at: clang/test/CodeGen/X86/avx512f-builtins.c:10853
+
+__m512i test_mm512_mask_i32logather_epi64(__m512i __v1_old, __mmask8 __mask, __m512i __index, void const *__addr) {
+  // CHECK-LABEL: @test_mm512_mask_i32logather_epi64
----------------
Any idea why _mm512_mask_i32loscatter_epi64 is documented as only being KNCI?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100368/new/

https://reviews.llvm.org/D100368