[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

Harald van Dijk via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 12 11:13:00 PDT 2021


hvdijk added a comment.

In D100148#2683748 <https://reviews.llvm.org/D100148#2683748>, @glaubitz wrote:

> Understood. However, I'm not really sure what else we need. Do we just take the architecture definition from here to pass the proper flags to the compiler or do we also need to add
> some x32-specific code?

My personal opinion: I would say to enable the compiler-rt bits that are already correct for x32, which should only require passing the proper flags. Beyond the libsanitizer bits, I do not know which other bits, if any, might already be correct for x32 though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100148/new/

https://reviews.llvm.org/D100148



More information about the cfe-commits mailing list