[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

John Paul Adrian Glaubitz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 12 11:03:58 PDT 2021


glaubitz added a comment.

In D100148#2683710 <https://reviews.llvm.org/D100148#2683710>, @hvdijk wrote:

> In D100148#2683325 <https://reviews.llvm.org/D100148#2683325>, @glaubitz wrote:
>
>> Hi! Can we get this patch merged as-is or do we need anything else?
>
> Sorry, miscommunication. I was thinking you could use this to update D99988 <https://reviews.llvm.org/D99988> to actually build the relevant compiler-rt bits for x32, and then once both that and this are ready, both can be submitted at the same time. The reason for that is that this is not useful by itself, and if it turns out that D99988 <https://reviews.llvm.org/D99988> actually requires some other clang change as well that we are not seeing yet, it will be easier to update this if it has not been pushed yet. Do you think it would be better to push this first?

Understood. However, I'm not really sure what else we need. Do we just take the architecture definition from here to pass the proper flags to the compiler or do we also need to add
some x32-specific code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100148/new/

https://reviews.llvm.org/D100148



More information about the cfe-commits mailing list