[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

Xun Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 11 22:47:55 PDT 2021


lxfind added a comment.

> Ah, if the pass does more than just setting the attribute, then sure, it makes sense to keep it.  But I do think we should be requiring the attribute to be added by frontends, since it's really an IR invariant that it's present on all unlowered coroutines.

By the way, it also sets these attributes for other types of coroutines (retcon and async). So the down-side would be then we need to do this for all front-ends (clang and swift).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100282/new/

https://reviews.llvm.org/D100282



More information about the cfe-commits mailing list