[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 11 22:46:41 PDT 2021


ChuanqiXu added a comment.

This patch looks OK to me.

> The best we can do is lower the coroutine and then inline the ramp function, which is not really the same thing. So warning about marking a coroutine always_inline does make some sense.

It makes sense to emit a warning instead of an error. The example above emits an error which is surprising.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100282/new/

https://reviews.llvm.org/D100282



More information about the cfe-commits mailing list