[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

In D99227#2646532 <https://reviews.llvm.org/D99227#2646532>, @rjmccall wrote:

> I am skeptical that it's reasonable to do this for *correctness*, however; I don't think the frontend unconditionally emits lifetime intrinsics.

Sorry, I re-read this after posting, and it's not exactly clear what I was saying.  There are a lot of situations where Clang doesn't emit lifetime intrinsics for every `alloca` it emits, or emits unnecessarily weak bounds.  Certain LLVM transforms can also introduce `alloca`s that don't have corresponding lifetime intrinsics.  So I think it's problematic to consider it a correctness condition that we're emitting optimally-tight lifetimes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99227/new/

https://reviews.llvm.org/D99227