[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 23 18:57:44 PDT 2021
rjmccall added a comment.
I have no objection to trying to always emit lifetime intrinsics in coroutines since it has a less-trivial runtime cost. I am skeptical that it's reasonable to do this for *correctness*, however; I don't think the frontend unconditionally emits lifetime intrinsics. But since I think this fine to do regardless, I have no objection to the patch.
I think you just set `ShouldEmitLifetimeMarkers` correctly in the first place instead of adding this as an extra condition to every place that considers it, however.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99227/new/
https://reviews.llvm.org/D99227
More information about the cfe-commits
mailing list