[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

Saurabh Jha via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 22 14:47:29 PDT 2021


SaurabhJha added a comment.

> I think you probably need to add new files for the tests, e.g. `matrix-type-casts.cpp` & `matrix-type-casts.c` and then just add tests for various valid cast combinations. Is that enough to get you started? You can look at some of the existing matrix codegen tests for inspiration for the run-line & CHECK lines.

Oh yes, missed the obvious thing I could have done, Cheers!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037



More information about the cfe-commits mailing list