[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

[Florian Hahn via Phabricator via cfe-commits]

fhahn added a comment.

Thanks for the patch! I think this also needs changes in code-gen & code-gen tests.

In D99037#2642598 <https://reviews.llvm.org/D99037#2642598>, @SaurabhJha wrote:

> In D99037#2640388 <https://reviews.llvm.org/D99037#2640388>, @fhahn wrote:
>
>> Thanks for the patch! I think this also needs changes in code-gen & code-gen tests.
>
> Hey @fhahn I searched but could not find the relevant code-gen and code-gen tests I need to fix. Can you please point me to where vectors casts are handled in code gen? I could probably use that for matrices.

I think you probably need to add new files for the tests, e.g. `matrix-type-casts.cpp` & `matrix-type-casts.c` and then just add tests for various valid cast combinations. Is that enough to get you started? You can look at some of the existing matrix codegen tests for inspiration for the run-line & CHECK lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037