[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

Valeriy Savchenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 19 23:00:25 PDT 2021


vsavchenko added inline comments.


================
Comment at: clang/test/Analysis/PR49642.c:1
+// RUN: %clang --analyze -Xclang -analyzer-checker=core %s
+
----------------
NoQ wrote:
> Why not the usual `%clang_analyze_cc1`? Your approach only adds driver testing which doesn't seem to test anything new. Also if you do `clang --analyze` you don't need to enable `core` explicitly, you already have all on-by-default checks running.
I didn't figure out how to reproduce the crash with `%clang_analyze_cc1` :-(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98948/new/

https://reviews.llvm.org/D98948



More information about the cfe-commits mailing list