[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.

Aha ok, seems reasonable, thx!



================
Comment at: clang/test/Analysis/PR49642.c:1
+// RUN: %clang --analyze -Xclang -analyzer-checker=core %s
+
----------------
Why not the usual `%clang_analyze_cc1`? Your approach only adds driver testing which doesn't seem to test anything new. Also if you do `clang --analyze` you don't need to enable `core` explicitly, you already have all on-by-default checks running.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98948/new/

https://reviews.llvm.org/D98948