[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

Thu Mar 18 09:00:01 PDT 2021

jrtc27 added a comment.

In D98113#2634758 <https://reviews.llvm.org/D98113#2634758>, @luismarques wrote:

> I just looked at this again and I don't have the full context in my mind right now but won't the test just exercise the BareMetal toolchain and not your changes?

I've since lost my recollection of all the details, but BareMetal::AddLinkRuntimeLib is hard-coding -lclang_rt.builtins-$ARCH so I think we already do search in the sysroot for the library if it doesn't exist in the resources directory. What this tests is -print-libgcc-file-name (implemented in the common Driver.cpp) which is the thing that is currently "broken" for bare-metal toolchains as it will currently neglect to search the sysroot as the linker would, since it calls getCompilerRT directly (which BareMetal doesn't override).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98113/new/

https://reviews.llvm.org/D98113