[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added a comment.

I tried reproducing the CI failures reported at the top (in particular `intrinsic_module_path.f90`), but haven't had much luck. @arnamoy10 - how about you?

Could you `clang-format` this patch when uploading the next diff? Thank you!



================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:319
+  // to the default location to search (currently hardcoded).
+  // TODO: identify a value for this default search directory
+  for (const auto *currentArg :
----------------
This `TODO` has been addressed, right?


================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:323
+    opts.searchDirectoriesFromIntrModPath.emplace_back(currentArg->getValue());
+  opts.searchDirectoriesFromIntrModPath.emplace_back(getIntrinsicDir());
 }
----------------
This method is meant for parsing input parameters, but the default directory for intrinsic modules is not a parameter. I think that `setFortranOpts` would be a better place for adding the default directory for `fortranOptions.searchDirectories`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97080/new/

https://reviews.llvm.org/D97080