[clang] 774b707 - Revert "Workaround a -Wmisleading-indentation warning"

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 15 18:57:07 PDT 2021


Would be great to include details of why the patch was reverted - helps
folks understand if this patch will address any issues they're seeing, or
help avoid someone causing the same problem with a similar patch in the
future.

On Wed, Mar 10, 2021 at 3:36 PM Stephen Kelly via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

>
> Author: Stephen Kelly
> Date: 2021-03-10T23:35:41Z
> New Revision: 774b707564e1eed8fec5b5874d0aa82628de0651
>
> URL:
> https://github.com/llvm/llvm-project/commit/774b707564e1eed8fec5b5874d0aa82628de0651
> DIFF:
> https://github.com/llvm/llvm-project/commit/774b707564e1eed8fec5b5874d0aa82628de0651.diff
>
> LOG: Revert "Workaround a -Wmisleading-indentation warning"
>
> This reverts commit 5c22e2bec008760cc7078d8d14382ef4762c5d54.
>
> Added:
>
>
> Modified:
>     clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py
> b/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py
> index aafae2c15b29..dee7a416e69a 100755
> --- a/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py
> +++ b/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py
> @@ -171,7 +171,7 @@ def GenerateDynNodeVisitor(self, CladeNames):
>      if (const auto *N = Node.get<{0}>())
>        return GetLocations(const_cast<{0} *>(N));""".format(CladeName)
>
> -        self.implementationContent += '\nreturn {}; }'
> +        self.implementationContent += 'return {}; }'
>
>      def GenerateEpilogue(self):
>
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210315/12ed39fc/attachment-0001.html>


More information about the cfe-commits mailing list