<div dir="ltr">Would be great to include details of why the patch was reverted - helps folks understand if this patch will address any issues they're seeing, or help avoid someone causing the same problem with a similar patch in the future.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 10, 2021 at 3:36 PM Stephen Kelly via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Stephen Kelly<br>
Date: 2021-03-10T23:35:41Z<br>
New Revision: 774b707564e1eed8fec5b5874d0aa82628de0651<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/774b707564e1eed8fec5b5874d0aa82628de0651" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/774b707564e1eed8fec5b5874d0aa82628de0651</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/774b707564e1eed8fec5b5874d0aa82628de0651.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/774b707564e1eed8fec5b5874d0aa82628de0651.diff</a><br>
<br>
LOG: Revert "Workaround a -Wmisleading-indentation warning"<br>
<br>
This reverts commit 5c22e2bec008760cc7078d8d14382ef4762c5d54.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py b/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py<br>
index aafae2c15b29..dee7a416e69a 100755<br>
--- a/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py<br>
+++ b/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py<br>
@@ -171,7 +171,7 @@ def GenerateDynNodeVisitor(self, CladeNames):<br>
     if (const auto *N = Node.get<{0}>())<br>
       return GetLocations(const_cast<{0} *>(N));""".format(CladeName)<br>
<br>
-        self.implementationContent += '\nreturn {}; }'<br>
+        self.implementationContent += 'return {}; }'<br>
<br>
     def GenerateEpilogue(self):<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>