[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Fri Mar 12 10:18:19 PST 2021

Anastasia added a comment.

In D97058#2622681 <https://reviews.llvm.org/D97058#2622681>, @svenvh wrote:

> In D97058#2622669 <https://reviews.llvm.org/D97058#2622669>, @thakis wrote:
>
>> Does it repro if you add `-target arm64-apple-macosx` as arg to c-index-test on the RUN line of that test?
>
> I also had trouble reproducing the failure locally, but by specifying this target I can reproduce the failure.
>
> That means the fix is simple then? Simply add `-target spir` to the test.

I can't get how this test could even work for other targets since it is using Intel's extension successfully. My guess is that `-target spir` might indeed be a proper fix. However, I am confused why it only started failing on this commit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97058/new/

https://reviews.llvm.org/D97058