[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

It repros for me with this local diff

  % git diff
  diff --git a/clang/test/Index/opencl-types.cl b/clang/test/Index/opencl-types.cl
  index 496f38752fa2..13f6058864b5 100644
  --- a/clang/test/Index/opencl-types.cl
  +++ b/clang/test/Index/opencl-types.cl
  @@ -1,4 +1,4 @@
  -// RUN: c-index-test -test-print-type %s -cl-std=CL2.0 | FileCheck %s
  +// RUN: c-index-test -test-print-type %s -cl-std=CL2.0 -target arm64-apple-macosx | FileCheck %s
  
   #pragma OPENCL EXTENSION cl_khr_fp16 : enable
   #pragma OPENCL EXTENSION cl_khr_fp64 : enable

The failure goes away if I locally revert the change.

I don't know if it's expected that the test added in https://reviews.llvm.org/D51484 starts failing after this change for arm triples. If it is, then just adding a fixed triple is fine. If it's unexpected, the let's revert and analyze async, with a green tree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97058/new/

https://reviews.llvm.org/D97058