[PATCH] D98379: [RISCV] Add additional checking to tablgen RISCVVEmitter requested in D95016.
Jessica Clarke via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 10 16:55:34 PST 2021
jrtc27 accepted this revision.
jrtc27 added a comment.
This revision is now accepted and ready to land.
Any TableGen backend error that's a real message and not an assertion failure with a backtrace is a win in my books :)
================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:627
default:
llvm_unreachable("Illegal non-primitive type transformer!");
}
----------------
Hm, if this is the actual parser then these should also be PrintFatalError (another instance earlier in the function, and one in applyBasicType)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98379/new/
https://reviews.llvm.org/D98379
More information about the cfe-commits
mailing list