[PATCH] D98379: [RISCV] Add additional checking to tablgen RISCVVEmitter requested in D95016.
Craig Topper via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 10 16:51:11 PST 2021
craig.topper created this revision.
craig.topper added reviewers: jrtc27, khchen.
Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb.
craig.topper requested review of this revision.
Herald added a subscriber: MaskRay.
Herald added a project: clang.
This errors, but doesn't give source location. We'd need to pass
the Record through several layers to get to the location.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D98379
Files:
clang/utils/TableGen/RISCVVEmitter.cpp
Index: clang/utils/TableGen/RISCVVEmitter.cpp
===================================================================
--- clang/utils/TableGen/RISCVVEmitter.cpp
+++ clang/utils/TableGen/RISCVVEmitter.cpp
@@ -19,6 +19,7 @@
#include "llvm/ADT/StringMap.h"
#include "llvm/ADT/StringSet.h"
#include "llvm/ADT/Twine.h"
+#include "llvm/TableGen/Error.h"
#include "llvm/TableGen/Record.h"
using namespace llvm;
@@ -594,9 +595,15 @@
for (char I : Transformer) {
switch (I) {
case 'P':
+ if (IsConstant)
+ PrintFatalError("'P' transformer cannot be used after 'C'");
+ if (IsPointer)
+ PrintFatalError("'P' transformer cannot be used twice");
IsPointer = true;
break;
case 'C':
+ if (IsConstant)
+ PrintFatalError("'C' transformer cannot be used twice");
IsConstant = true;
break;
case 'K':
@@ -613,7 +620,7 @@
break;
case 'S':
LMUL = LMULType(0);
- // Update ElementBitwidth need ot update Scale too.
+ // Update ElementBitwidth need to update Scale too.
Scale = LMUL.getScale(ElementBitwidth);
break;
default:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98379.329804.patch
Type: text/x-patch
Size: 1141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210311/cb7e3891/attachment.bin>
More information about the cfe-commits
mailing list