[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

[Manoj Gupta via Phabricator via cfe-commits]

manojgupta added a comment.

In Chrome OS, we currently both "-B" and "--prefix". "-B" points to binutils bin directory and the "--prefix" has the binutils directory + target suffix. Should we drop "-B" and still get the same behavior?

Sample invocation: '/usr/bin/clang++' '--sysroot=/usr/x86_64-cros-linux-gnu '-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics' '-fcommon' '-fstack-protector-strong' '-fPIE' '-pie' '-D_FORTIFY_SOURCE=2' '-fno-omit-frame-pointer' '--prefix=../../../../../../usr/libexec/gcc/x86_64-cros-linux-gnu/x86_64-cros-linux-gnu-' 'foo.o' '-o' 'main' '-B../../../../../../usr/libexec/gcc/x86_64-cros-linux-gnu' '-target' 'x86_64-cros-linux-gnu'

I am not yet able to test this change in Chrome OS thoroughly yet because of some CQ issues. But manually checking the command lines for a few common cases does not show any difference so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97894/new/

https://reviews.llvm.org/D97894