[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 4 11:02:58 PST 2021


MaskRay added a comment.

In D97894#2602638 <https://reviews.llvm.org/D97894#2602638>, @mgorny wrote:

> Well, I think this was mostly 'just in case' condition, so I guess it's fine. Let's just wait for @manojgupta to give it some more testing.

Thanks. I sent D97902 <https://reviews.llvm.org/D97902> to improve the documentation. Dropping the special case makes it more consistent: if --gcc-toolchain is not empty, suppress sysroot GCC detection

With the special rule, it is: if --gcc-toolchain is $sysroot/usr, suppress sysroot GCC detection as well.

Clang -B and --gcc-toolchain have some weird behaviors. Hope you can share your opinions on https://lists.llvm.org/pipermail/cfe-dev/2021-March/067827.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97894/new/

https://reviews.llvm.org/D97894



More information about the cfe-commits mailing list