[PATCH] D93164: [AST] Add generator for source location introspection
Stephen Kelly via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 28 11:10:52 PST 2021
steveire marked 2 inline comments as done.
steveire added inline comments.
================
Comment at: clang/include/clang/Tooling/NodeIntrospection.h:54
+public:
+ static std::string format(LocationCall *Call) {
+ std::vector<LocationCall *> vec;
----------------
njames93 wrote:
> Should this (and potential a few others) be moved to an implementation file.
The implementation file is generated by the python script. Rather than hiding this in the python script, I think it's better to leave it here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93164/new/
https://reviews.llvm.org/D93164
More information about the cfe-commits
mailing list