[PATCH] D93164: [AST] Add generator for source location introspection

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 28 11:08:01 PST 2021


steveire marked 3 inline comments as done.
steveire added inline comments.


================
Comment at: clang/lib/Tooling/DumpTool/ASTSrcLocProcessor.cpp:22-25
+auto publicAccessor = [](auto... InnerMatcher) {
+  return cxxMethodDecl(isPublic(), parameterCountIs(0), isConst(),
+                       InnerMatcher...);
+};
----------------
njames93 wrote:
> Why is this a variable, a templated function should do the same thing.
> I imagine its something like this.
That seems far more noisy. I've left it as a lambda and moved it to the point of use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93164/new/

https://reviews.llvm.org/D93164



More information about the cfe-commits mailing list