[PATCH] D88220: [C++20] P1825R0: More implicit moves

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 23 16:29:29 PST 2021


aaronpuchert added a comment.

In D88220#2581538 <https://reviews.llvm.org/D88220#2581538>, @aaron.ballman wrote:

> We usually rely on the release notes to say something, but we didn't do that here.

Perhaps @nullptr.cpp could add something there? The file is `clang/docs/ReleaseNotes.rst`.

> As for using `-Woption-ignored`... I am not certain we want it directly under that flag, but it may make sense as a subgroup of `-Woption-ignored`. e.g., I can imagine a use case where someone wants to silence that they're using a deprecated flag (so their -Wx builds continue to compile) but still wants to be warned when they use a option that's ignored for other reasons.

You're right, the other flags `-Woption-ignored` warns about seem to have an effect on compilation such that one might want to be warned if they're ignored. Which isn't the case here, I guess.

Also it's probably Ok if people just see that the warning no longer exists and then remove it, or remove it based on the compiler version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88220/new/

https://reviews.llvm.org/D88220



More information about the cfe-commits mailing list