[PATCH] D88220: [C++20] P1825R0: More implicit moves

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 23 05:35:19 PST 2021


aaron.ballman added a comment.

In D88220#2573018 <https://reviews.llvm.org/D88220#2573018>, @aaronpuchert wrote:

> In D88220#2571911 <https://reviews.llvm.org/D88220#2571911>, @amccarth wrote:
>
>> Would anyone object to allowing the option but silently ignoring it, at least for a transition period?
>
> No objection from me.

Nor from me.

>> Was there prior notice of this option being deprecated?
>
> I don't think we have a way to deprecate warning flags. We could perhaps put something under `-Woption-ignored`.
>
> @aaron.ballman, what do you think about this?

We don't have a loud way of deprecating them (that I'm aware of). We usually rely on the release notes to say something, but we didn't do that here. As for using `-Woption-ignored`... I am not certain we want it directly under that flag, but it may make sense as a subgroup of `-Woption-ignored`. e.g., I can imagine a use case where someone wants to silence that they're using a deprecated flag (so their -Wx builds continue to compile) but still wants to be warned when they use a option that's ignored for other reasons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88220/new/

https://reviews.llvm.org/D88220



More information about the cfe-commits mailing list